Conversation
Collaborator
pmenendz
commented
Jul 11, 2025
- Support chat context
- Allow checkpointer None
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for passing chat context messages to the agent and makes the checkpointing mechanism configurable (including allowing no checkpointer).
- Introduce
checkpointerproperty inConfigto select or disable a saver - Remove hardcoded in-memory saver in the agent and wire through the config
- Add
get_response_with_contextto reuse streaming logic with arbitrary message history
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/expert/config.py | Add checkpointer property to select/disable savers |
| src/expert/agent.py | Remove hardcoded InMemorySaver, inject config checkpointer, add context-aware methods |
Comments suppressed due to low confidence (1)
src/expert/config.py:108
- New match-case branches for the checkpointer configuration ('memory' and None) are introduced but not covered by existing tests. Consider adding unit tests to verify each branch behaves as expected.
match checkpointer:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.