Align French tax point translations with XP Z12-012 spec#103
Merged
methodofaction merged 2 commits intomainfrom Apr 23, 2026
Merged
Align French tax point translations with XP Z12-012 spec#103methodofaction merged 2 commits intomainfrom
methodofaction merged 2 commits intomainfrom
Conversation
The French translations for tax point values and labels were out of step with the official French e-invoicing specification (XP Z12-012 Annexe A, BT-7 / BT-8). The code-list option for an issue-date tax point in the spec is "Date de la facture", not "Date d'émission", and the field itself is "Date d'exigibilité de la TVA" rather than "Fait générateur" (which the spec uses only to describe the underlying concept). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates French locale labels for tax point fields (BT-7/BT-8) to match the XP Z12-012 specification terminology.
Changes:
- Replace
taxable_event/taxable_event_dateFrench labels from “Fait générateur” wording to “Exigibilité TVA” / “Date d'exigibilité de la TVA”. - Update
tax_points.issueFrench label from “Date d'émission” to “Date de la facture”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #102. The French translations for the tax point (BT-7 / BT-8) were not aligned with the official French e-invoicing specification (XP Z12-012 Annexe A — Règles de gestion). This PR corrects them based on the spec document.
Changes in
locales/fr/app.ymltaxable_eventtaxable_event_datetax_points.issuetax_points.deliverytax_points.paymentWhy
Per XP Z12-012 Annexe A:
BT-7 / BT-8 (row F12 / F13) is officially named "Date d'exigibilité de la taxe sur la valeur ajoutée" — not "Fait générateur". The spec explicitly notes that "fait générateur" is the underlying concept, but the field itself is "date d'exigibilité".
BT-8 code values (row T13) are listed as:
So
issuein particular was wrong — it should be "Date de la facture", not "Date d'émission".Only the French locale is affected. The other locales and the English example outputs are unchanged.
Test plan
go test ./...passes🤖 Generated with Claude Code