Skip to content

Add CUIT label for Argentine tax IDs#104

Merged
methodofaction merged 1 commit intomainfrom
ar-cuit
Apr 27, 2026
Merged

Add CUIT label for Argentine tax IDs#104
methodofaction merged 1 commit intomainfrom
ar-cuit

Conversation

@methodofaction
Copy link
Copy Markdown
Contributor

@methodofaction methodofaction commented Apr 25, 2026

Fixes APP-471

Summary

  • Argentine parties were rendering with the generic "TIN" fallback in taxIDLabel. Added an AR case so they display CUIT, matching local convention.
  • Regenerated party_templ.go via templ generate and updated the three ar-arca-* example snapshots accordingly.

Note: the linked Linear issue also mentions IIBB and a missing state — this PR only addresses the CUIT label. Those remain to be tackled.

Test plan

  • go build ./...
  • go test ./...
  • Spot-check rendered Argentine invoice in the gallery / browser

🤖 Generated with Claude Code

Argentine parties were rendering with the generic "TIN" fallback
label. Add an "AR" case to taxIDLabel so they display "CUIT" instead,
matching the local convention.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Argentina-specific tax ID label so Argentine parties no longer fall back to the generic “TIN” label, aligning rendered documents with local convention (“CUIT”).

Changes:

  • Add AR handling in taxIDLabel to return CUIT.
  • Regenerate party_templ.go from party.templ.
  • Update the three Argentina (ARCA) HTML example snapshots to reflect the new label.

Reviewed changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
examples/out/ar-arca-liquido-producto.html Snapshot update: “TIN” → “CUIT” for AR tax IDs.
examples/out/ar-arca-invoice.html Snapshot update: “TIN” → “CUIT” for AR tax IDs.
examples/out/ar-arca-invoice-logo.html Snapshot update: “TIN” → “CUIT” for AR tax IDs.
components/org/party_templ.go Generated output updated to include the new ARCUIT switch case.
components/org/party.templ Source template updated: add ARCUIT tax ID label.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@pmenendz pmenendz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@methodofaction methodofaction merged commit 3bedd8b into main Apr 27, 2026
10 checks passed
@methodofaction methodofaction deleted the ar-cuit branch April 27, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants