Support marshal with linebreak and indent and support ignore specific struct field#150
Open
funte wants to merge 7 commits intoinvopop:mainfrom
Open
Support marshal with linebreak and indent and support ignore specific struct field#150funte wants to merge 7 commits intoinvopop:mainfrom
funte wants to merge 7 commits intoinvopop:mainfrom
Conversation
samlown
requested changes
Oct 7, 2024
Contributor
samlown
left a comment
samlown
left a comment
There was a problem hiding this comment.
Tests are essential here to understand what you're trying to achieve. Also, I'm not sure indentation should be handled in the MarshalJSON method.
Comment on lines
+1092
to
+1094
| var MarshalWithIndent = false | ||
| var MarshalPrefix = "" | ||
| var MarshalIndent = "\t" |
Contributor
There was a problem hiding this comment.
Global variables should be avoided. Wouldn't you want to do this with the regular json.MarshalIndent method directly?
| IgnoredTypes []any | ||
|
|
||
| // Ignore specific struct field, enable dynamic generate different schemas from on struct. | ||
| Ignore func(reflect.StructField) bool |
Contributor
There was a problem hiding this comment.
Its not clear how this should be used... as a rule, I'd try to avoid using reflect types directly.
Codecov. Minor renaming of comments handler
Add a custom mechanism for looking up comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema.MarshalJSONmarshal json with linebreak and indent, the default json output is still compact;Reflector.Ignoremethod to ignore specific struct field, enable dynamic generate different schemas from one struct.