chore: remove incorrectly named ToSnakeCase func#180
Open
tobikris wants to merge 1 commit intoinvopop:mainfrom
Open
chore: remove incorrectly named ToSnakeCase func#180tobikris wants to merge 1 commit intoinvopop:mainfrom
tobikris wants to merge 1 commit intoinvopop:mainfrom
Conversation
3e5ff69 to
cb81440
Compare
samlown
approved these changes
Mar 31, 2026
Contributor
samlown
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me!
There was a problem hiding this comment.
Pull request overview
This PR removes the misnamed ToSnakeCase helper (which produced kebab-case) and switches schema ID generation to use github.com/stoewer/go-strcase’s KebabCase, aligning implementation with the documented recommendation.
Changes:
- Removed the internal
ToSnakeCaseimplementation fromutils.go. - Updated schema
$idgeneration to usestrcase.KebabCase. - Added
github.com/stoewer/go-strcasetogo.mod/go.sum.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| utils.go | Removes the exported ToSnakeCase helper implementation. |
| reflect.go | Uses strcase.KebabCase for schema ID generation and updates related comment wording. |
| go.mod | Adds github.com/stoewer/go-strcase dependency. |
| go.sum | Records checksums for the new dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samlown
approved these changes
Apr 23, 2026
Contributor
|
If you could, please update this branch with main (or grant me permissions to commit). Thanks! |
The function was supposed to convert to kebab-case, but named ToSnakeCase. It was removed in favor of using the github.com/stoewer/go-strcase package's KebabCase. This package was already suggested in the documentation anyway.
Author
|
I have rebased this branch 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function was supposed to convert to kebab-case, but named ToSnakeCase. It was removed in favor of using the github.com/stoewer/go-strcase package's KebabCase. This package was already suggested in the documentation anyway.
I verified that this change has no unwanted effects with the following test - no changes in the meaningful cases.