Replace wk8/go-ordered-map with pb33f/ordered-map#189
Merged
Conversation
pb33f/ordered-map is an API-compatible fork of wk8/go-ordered-map that drops the transitive dependency on github.com/mailru/easyjson, which has been flagged as a supply-chain risk due to its maintainers' affiliation with VK Group. Refs: #182 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 4 4
Lines 732 732
=======================================
Hits 654 654
Misses 59 59
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/wk8/go-ordered-map/v2for its API-compatible forkgithub.com/pb33f/ordered-map/v2.github.com/mailru/easyjson, which has been flagged as a supply-chain risk due to its maintainers' affiliation with VK Group (see Consider removing easyjson dependency due to security risks #182).OrderedMap[K, V]type,New[K, V]()constructor, andSet/Get/Deletemethods used by this library are unchanged, soNewProperties()andSchema.Propertieskeep the same shape.go mod tidyalso bumps thestretchr/testifyminimum to v1.11.1 (required by pb33f) and pulls ingo.yaml.in/yaml/v4as a new indirect dep.Compatibility note
Consumers that reference the fully-qualified type
*orderedmap.OrderedMap[string, *Schema](e.g. when constructing aSchemaliteral) will need to update their import fromgithub.com/wk8/go-ordered-map/v2togithub.com/pb33f/ordered-map/v2. Users ofjsonschema.NewProperties()are unaffected. Worth calling out in release notes.Fixes #182
Test plan
go build ./...go vet ./...go test ./...go mod why -m github.com/mailru/easyjsonconfirms it is no longer a dependency🤖 Generated with Claude Code