Add NoSynopsis option to AddGoComments#67
Conversation
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
|
Looks good @gmlewis from the outset, but it needs some tests! |
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Sorry for the delay. I added tests. PTAL. |
samlown
left a comment
samlown
left a comment
There was a problem hiding this comment.
A few people are trying to deal with this, so I appreciate its important. A think a simpler approach without the configuration helpers methods would be best at the moment.
| // ExtractGoCommentsOption represents an option that can be passed to ExtractGoComments | ||
| // in order to modify its behavior. | ||
| type ExtractGoCommentsOption func(e *extractOptions) |
There was a problem hiding this comment.
I do like this approach for option handling! But I think at the moment it is too inconsistent with the current approach (unfortunately). I have a plan in mind to refactor all configuration towards config methods.
|
There are any news about this PR? I'm looking for this feature also |
If I'm not mistaken, I'm waiting for the following to happen, correct?
Or is there something I'm supposed to do to this PR in the meantime? |
3 participants
Fixes: #66.