Add ZATCA rule set#9
Open
migueltorresvalls wants to merge 2 commits intomainfrom
Open
Conversation
migueltorresvalls
changed the title
There was a problem hiding this comment.
Pull request overview
Adds Saudi Arabia (ZATCA) e-invoicing validation support via phive-rules, and introduces a targeted fallback to recover from a known SVRL/JAXB parsing failure in the ZATCA Schematron layer.
Changes:
- Register ZATCA validation rules in the Phive rules initializer.
- Add the
phive-rules-zatcaMaven dependency. - Add a ZATCA-specific Schematron SVRL fallback path that re-runs the XSLT and parses SVRL with schema validation disabled after stripping whitespace-only text nodes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main/java/rpc/ValidationServiceImpl.java |
Adds ZATCA Schematron SVRL fallback re-parse logic and uses the “effective” result when building layer output. |
src/main/java/config/PhiveRulesInitializer.java |
Registers the ZATCA ruleset via reflection-based initializer. |
pom.xml |
Adds phive-rules-zatca dependency to include the ZATCA ruleset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
18
to
31
| import java.nio.charset.StandardCharsets; | ||
| import java.time.Instant; | ||
| import java.util.Locale; | ||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import org.w3c.dom.Document; | ||
| import org.w3c.dom.Element; | ||
| import org.w3c.dom.Node; | ||
| import org.w3c.dom.NodeList; | ||
|
|
||
| import com.helger.collection.commons.ICommonsList; | ||
| import com.helger.diagnostics.error.level.IErrorLevel; | ||
| import com.helger.diagnostics.error.list.ErrorList; |
There was a problem hiding this comment.
Unused imports java.nio.charset.StandardCharsets and com.helger.diagnostics.error.level.IErrorLevel remain in this file but are not referenced anywhere. Please remove them to keep the file clean and avoid lint/build failures if unused-import checks are enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.