fix: handle empty editor state to clear graph and validation#188
Open
sakshammjn wants to merge 1 commit into
Open
fix: handle empty editor state to clear graph and validation#188sakshammjn wants to merge 1 commit into
sakshammjn wants to merge 1 commit into
Conversation
|
Great fix! I was going through the issue and noticed the root cause was the early return skipping state reset. One thought — would it also make sense to explicitly reset any cached/derived state (if present) to avoid inconsistencies in future updates? Also, are there any edge cases around whitespace-only input or rapid toggling between formats that we should guard against? Happy to help test or contribute further if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes how the app behaves when the editor is empty.
Before this change, if all text was deleted from Monaco, the graph could still stay on screen and the validation bar could still look valid. Also, switching JSON/YAML while empty could bring back default content.
Now, when the editor is empty:
What kind of change does this PR introduce
Bug fix
Issue Number
Closes #180
Video
screen.recording.for.pr.mov
Does this PR introduce a breaking change?
No
If relevant, did you update the documentation?
No need to update the documentation