fix: create fresh Dagre graph instance per layout call#203
Open
vanshaj2023 wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
Hi @AgniveshChaubey @jagpreetrahi |
Contributor
|
version bump is required |
Contributor
Author
|
Done, Please check this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
dagreGraphinstantiation from module scope intogetLayoutedElementsso each schema change starts with a fresh Dagre graph, preventing stale nodes from prior schemas polluting layout calculations.What kind of change does this PR introduce
Bug fix
Issue Number
Closes #199
Screenshots/Video
N/A — layout correctness fix, no visual regression introduced.
Does this PR introduce a breaking change?
No
If relevant, did you update the documentation?
No