Feat : Implement topological sorting #361
Open
itvi-1234 wants to merge 1 commit into
Open
Conversation
Contributor
Preview Deployed!
Last updated at 2026-07-07T10:27:41Z |
itvi-1234
changed the title
Contributor
Author
|
Hey @AgniveshChaubey & @jagpreetrahi , could you please review this PR whenever have some time |
jagpreetrahi
reviewed
Jul 3, 2026
jagpreetrahi
left a comment
jagpreetrahi
left a comment
Collaborator
There was a problem hiding this comment.
Hey @itvi-1234 ,
Can we have the better type in place of any within the code. And also using the non-null assertion operator is reasonable call here due to the empty array that would be return undefined but can we somehow to stop using it since the future refactor could silently break the invariant.
Signed-off-by: itvi-1234 <rjsumit71@gmail.com>
Contributor
Author
|
Hi @jagpreetrahi , Thanks for the suggestions , I have pushed some changes , could you please take a look ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implement topological sorting using Khan's algorithm
Closes #334