Validate ZIP uploads before writing to disk - #311
Open
vedayeminedi wants to merge 1 commit into
Open
Conversation
|
🎉 Thank you @vedayeminedi for submitting a Pull Request! We're excited to review your contribution. Before Review✅ Ensure all CI checks pass ⚡ Want faster reviews and contributor support? Join our Discord community: 🔗 https://discord.gg/FcXuyw2Rs Maintainers and mentors are active there and can help resolve blockers quickly. Happy Contributing! 🚀 |
|
✅ PR template check passed! @arpit2006 this PR is ready for your review. 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #305
What this PR does
Adds early validation for uploaded project archives in the
/scanendpoint. Previously, any uploaded file was written to disk before being validated as a ZIP archive. This PR rejects non-ZIP uploads with a415 Unsupported Media Typeresponse before any file I/O occurs and adds a test to verify the behavior.Type of change
ML tier (if applicable)
Stack affected
Changes
Backend
.zip.415 Unsupported Media Typewith a clear error message.Frontend
New dependencies
Database / schema changes
Testing
How did you test this?
3 passed).Checklist
console.erroror unhandled Python exceptions introducedrequirements.txt/package.jsonupdated if new dependencies added (Not applicable).pkl,.pt, etc.) are gitignored, not committed (Not applicable)Anything reviewers should focus on
Please review the early validation logic to ensure non-ZIP uploads are rejected before any file is written to disk and that the added regression test covers the expected behavior.
Screenshots (if UI changed)
N/A (Backend-only changes)