Skip to content

fix: migrate startup event to lifespan context manager - Fixes #306 #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ionfwsrijan merged 3 commits into from
Aug 1, 2026
Merged

fix: migrate startup event to lifespan context manager - Fixes #306 #344

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51899c5
fix: migrate startup event to lifespan context manager - Fixes #306
Tirthpanchori Jul 31, 2026
7b29bea
fix: correct import order per ruff (I001)
Tirthpanchori Jul 31, 2026
faf96ec
fix: apply ruff formatting to lifespan block
Tirthpanchori Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions backend/app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import tempfile
import threading
import uuid
from contextlib import asynccontextmanager
from datetime import datetime, timezone
from pathlib import Path
from typing import List
Expand Down Expand Up @@ -94,7 +95,17 @@
MAX_UPLOAD_SIZE = MAX_UPLOAD_MB * 1024 * 1024

logger = logging.getLogger(__name__)
app = FastAPI(title="PatchPilot API", version="0.1.0")


@asynccontextmanager
async def lifespan(app: FastAPI):
await init_db()
# Start background cleanup for finished ACTIVE_SCANS entries
asyncio.create_task(_cleanup_active_scans_loop())
yield


app = FastAPI(title="PatchPilot API", version="0.1.0", lifespan=lifespan)

ALLOWED_ORIGINS = [
"http://localhost:5173",
Expand Down Expand Up @@ -128,13 +139,6 @@
ensure_dir(WORK_ROOT)


@app.on_event("startup")
async def startup():
await init_db()
# Start background cleanup for finished ACTIVE_SCANS entries
asyncio.create_task(_cleanup_active_scans_loop())


@app.get("/health")
def health():
scanners = {
Expand Down
Loading