docs(autofill-credentials): Add warning about hostname and apis #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A big footgun for me when implementing server.hostname to match my live site was the app stopped working because it was making network requests to the same domain.com/api which Capacitor was routing internally to itself instead.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
giralte-ionic
requested review from
IT-MikeS,
ItsChaceD,
jcesarmobile,
markemer and
theproducer
|
This should definitely be in the docs. I spent hours figuring out why it didn't work although everything else was set up properly. |
|
Please can this be reviewed and merged, I've also wasted hours on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big footgun for me when implementing server.hostname to match my live site was the app stopped working because it was making network requests to the same domain.com/api which Capacitor was routing internally to itself instead.