Skip to content

feat(types): add versioning to MoveAuthenticator#1002

Open
Copilot wants to merge 8 commits intodevelopfrom
copilot/add-versioning-to-moveauthenticator
Open

feat(types): add versioning to MoveAuthenticator#1002
Copilot wants to merge 8 commits intodevelopfrom
copilot/add-versioning-to-moveauthenticator

Conversation

Copy link
Contributor

Copilot AI commented Mar 4, 2026

MoveAuthenticator lacked versioning, making its BCS serialization incompatible with the IOTA node's MoveAuthenticatorInner enum (introduced in iotaledger/iota#10431).

Copilot AI changed the title [WIP] Add versioning to MoveAuthenticator for BCS serialization compatibility Add versioning to MoveAuthenticator Mar 4, 2026
@Thoralf-M Thoralf-M force-pushed the copilot/add-versioning-to-moveauthenticator branch from dc87c99 to e7640f2 Compare March 6, 2026 18:00
@Thoralf-M Thoralf-M changed the title Add versioning to MoveAuthenticator feat(types): add versioning to MoveAuthenticator Mar 7, 2026
@Thoralf-M Thoralf-M marked this pull request as ready for review March 7, 2026 10:12
@Thoralf-M Thoralf-M requested a review from a team as a code owner March 7, 2026 10:12
@Thoralf-M Thoralf-M force-pushed the copilot/add-versioning-to-moveauthenticator branch from 0b5f65e to 5c13dd8 Compare March 7, 2026 10:14
/// Input objects or primitive values
call_args: Vec<Input>,
/// Type arguments for the Move authenticate function
#[cfg_attr(feature = "schemars", schemars(with = "Vec<String>"))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag should not be necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this changed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the versioned MoveAuthenticator happened with 1.18

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but actually we need a binary to be built with the updated SDK for the examples to pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants