You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added missing types/fields that are defined in the graphql schema but were missing in the query types. Only the validator fields I left commented out as these would make the query too big and make it fail: Query error: [Query payload is too large. The maximum allowed is 5000 bytes]
Also changed the iota_total_supply type to work, as the number it holds is larger than i32::MAX and decoding failed without this change
Considering that users can create their own queries and call run_query or run_query_from_json, do we really want to do this? Especially considering that queries can reach a byte limit, I feel that this is unnecessary.
Considering that users can create their own queries and call run_query or run_query_from_json, do we really want to do this? Especially considering that queries can reach a byte limit, I feel that this is unnecessary.
TBH I'm also not sure about it, but the query now still has the size that is fine and this way more data is available to the users (also the structs in the crate are a good example one can copy paste and modify). Building custom queries makes sense to make the queries more efficient, but is also a bit harder/more annoying to do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing types/fields that are defined in the graphql schema but were missing in the query types. Only the validator fields I left commented out as these would make the query too big and make it fail:
Query error: [Query payload is too large. The maximum allowed is 5000 bytes]Also changed the iota_total_supply type to work, as the number it holds is larger than i32::MAX and decoding failed without this change