Open
Conversation
Alex6323
commented
Feb 18, 2026
Thoralf-M
reviewed
Feb 18, 2026
Alex6323
force-pushed
the
feat/update-transaction-effects
branch
from
5e05157 to
bb9b63e
Compare
Thoralf-M
reviewed
Feb 26, 2026
Thoralf-M
approved these changes
Feb 26, 2026
crates/iota-sdk-transaction-builder/src/builder/client_methods.rs
Outdated
Show resolved
Hide resolved
| assert!(effects.is_ok(), "Execution failed. Effects: {effects:?}"); | ||
| // check that it succeeded | ||
| let status = effects.unwrap(); | ||
| let effects = effects.unwrap().into_v1(); |
Contributor
There was a problem hiding this comment.
We should probably have a match for places like this so we'll know to update them if we add new versions
Alex6323
force-pushed
the
feat/update-transaction-effects
branch
from
6cc65b9 to
8579bce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
enum_dispatchconvenience to the SDK for the monorepo by introducingTransactionEffectsAPItrait and implementing its methods.Splits the
TransactionEffectsApitrait, so that methods "for_testing" are separated.