test(sdk): comprehensive coverage boost for iota-sdk-types and iota-sdk-crypto #596
Open
abhiraj-mengade wants to merge 1 commit intoiotaledger:developfrom
Open
Conversation
3 tasks
8e49e42 to
d1b67c4
Compare
Achieved a total coverage improvement of +5.10% across the targeted crates. Breakdown by Crate: - `iota-sdk-types`: Increased by ~11.6% (from ~68.9% to 80.5%). - `iota-sdk-crypto`: Increased by ~0.9% (from ~96.2% to 97.1%). Total Impact: - Combined Coverage: 92.1% (+5.1%). - Net New Covered Lines: +2,418.
d1b67c4 to
4b0417a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR significantly improves test coverage across the core SDK crates, specifically targeting
iota-sdk-typesandiota-sdk-cryptowith an overall ~5.1% increase. ~109 new unit tests** were added, providing comprehensive validation for multisig verification, transaction effects, and cryptographic logic.📈 Coverage Impact
iota-sdk-typesiota-sdk-crypto(Note:
iota-sdk-cryptohas a high baseline due to large generated constant files, but critical logical components like multisig saw massive improvements from 0% to ~75%)Key Module Improvements
iota-sdk-crypto/multisig.rs):0%→75.1%— Fully covered threshold validation, signature aggregation, and bitmap logic.iota-sdk-types/framework.rs):0%→100%— Complete coverage forCoinstructs and object conversions.iota_namesmodules):~0%→~93%— Covered registry, configuration, and name record expiration logic.effects/mod.rs):~60%→92%— Added exhaustive accessor tests for transaction effects.gas.rs):~30%→95%— Added comprehensive tests forGasCostSummarycomputation.🛠 Changes Overview
iota-sdk-typesImprovementsframework.rs(Coin),gas.rs, andiota_namesspecific logic.TransactionEffectsenum accessors ineffects/mod.rsandv1.rs.NameRecordserialization iniota_names/registry.rs.hash.rsaddress derivation (zkLogin, etc.) andmove_package.rsupgrade policies.iota-sdk-cryptoImprovementsMultisigVerifier, bitmap operations, and public key aggregation.bls12381(+42%),ed25519(+45%),secp256k1(+43%), andsecp256r1(+43%).✅ Verification
All tests passed with
--all-features:Closes #504