feat: Command improvements#968
Draft
thibault-martinez wants to merge 10 commits intomove-core-sdkfrom
Draft
Conversation
Alex6323
reviewed
Feb 18, 2026
| /// argument-nested-result = %x03 u16 u16 | ||
| /// ``` | ||
| #[derive(Clone, Copy, Debug, PartialEq, Eq)] | ||
| #[derive(Debug, PartialEq, Eq, Hash, Clone, Copy)] |
Contributor
There was a problem hiding this comment.
style: not sure why Clone, Copy come last in this particular case?
thibault-martinez
force-pushed
the
replace-Command
branch
from
b7adcd4 to
0cf4d1a
Compare
Thoralf-M
reviewed
Mar 4, 2026
Comment on lines
+1220
to
+1232
| pub fn non_system_packages_to_be_published(&self) -> Option<&Vec<Vec<u8>>> { | ||
| match self { | ||
| Command::Publish(cmd) => Some(&cmd.modules), | ||
| Command::Upgrade(cmd) => Some(&cmd.modules), | ||
| Command::MoveCall(_) | ||
| | Command::TransferObjects(_) | ||
| | Command::SplitCoins(_) | ||
| | Command::MergeCoins(_) | ||
| | Command::MakeMoveVector(_) => None, | ||
| } | ||
| } | ||
|
|
||
| pub fn is_input_arg_used(&self, input_arg: u16) -> bool { |
Member
There was a problem hiding this comment.
Add some comments like
/// If this is a Publish or Upgrade command, return the modules to
/// publish. Returns None for all other command types.
/// Returns `true` if the command uses an input argument at the given index.
Contributor
There was a problem hiding this comment.
This is another one of those methods I think should be defined locally, unless this is somehow used everywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.