Draft
Conversation
Collaborator
|
Hi @mattwigway, Tests on master weren't passing earlier. Could you please merge master to your branch so that the tests can run properly. |
Member
|
@mattwigway , is there some documentation somewhere about what changes can be done through the config.json file ? |
Contributor
Author
|
Not really. I was leaving this in draft until conveyal/r5#974 is reviewed, because these changes don't do much interesting without that |
71cf120 to
c693e4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks for a config.json file in the network folder, and if it finds one, deserializes it as a TransportNetworkConfig object and uses that in creating the street network. This enables changing the traversalPermissionLabeler.
This is a draft because there are a number of other config fields that are not currently supported by r5r:
I'm kind of inclined to just check for these unsupported features and give an error if the user attempts to use any of them, while allowing use of the other config features.