Skip to content

Fix typing problems with http_requests and requests_wrapper #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix typing problems with http_requests and requests_wrapper #290

wants to merge 3 commits into from

Conversation

c0llab0rat0r
Copy link
Contributor

Most remaining issues (after this pr) are due to:

  • urllib3 not having enough type info
  • mypy not supporting mixins well (or perhaps we are not using mixins correctly with mypy)

@c0llab0rat0r
Copy link
Contributor Author

@ntninja this is ready for review but I don't think it should be merged until after the 0.8.0 release since its somewhat of an invasive refactor.

#289 should go first be merged for 0.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@c0llab0rat0r