feat: NewDAGProvider to walk partial DAGs in offline mode #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhinav Prakash <[email protected]>
Signed-off-by: Abhinav Prakash <[email protected]>
Signed-off-by: Abhinav Prakash <[email protected]>
The DAG provider creates a KeyChanFunc for all the CIDs found traversing the merkledag from given root. It can be used to provide specific DAGs (i.e. MFS) from their root.
This adds a SkipNotFound option to the FetcherConfig skips branch traversal when the blockservice returns ipld.NotFound. The result is that the fetcher is able to traverse dags in offline mode.
This was referenced Apr 2, 2025
This reverts commit e08fc17. because ipld-prime casts to traversal.SkipMe{}, and doesn't use errors.Is() https://github.com/ipld/go-ipld-prime/blob/7879a2ec4c5a4b7331fb9c80db9d41cbe463c0b9/traversal/walk.go#L410
gammazero
reviewed
Apr 8, 2025
this is internal error used for signaling inside of https://github.com/ipld/go-ipld-prime/tree/master/traversal/ afaict it has not impact on announced CIDs, and should not be logged as ERROR
lidel
commented
Apr 9, 2025
There was a problem hiding this comment.
lgtm, tested locally with ipfs/kubo#10754 and expected CIDs are provided as expected
the skip "ERROR" was moved to debug log level as it did not seem to block root from being correctly provided – ipfs/kubo#10754 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More context:
This PR is local continuation of #847 (in actuality, it was @hsanjuan rewriting most of original code) allowing for use in ipfs/kubo#10754 without pointing at a fork.