Skip to content

[WIP] Log requests from the CLI #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Log requests from the CLI #111

wants to merge 1 commit into from

Conversation

schomatis
Copy link
Contributor

Addresses #109.

@ghost ghost assigned schomatis May 21, 2018
@ghost ghost added the status/in-progress In progress label May 21, 2018
@schomatis
Copy link
Contributor Author

@keks Where would be a good point in the execution flow of a CLI command to test if the command was correctly registered in the request logger?

@schomatis
Copy link
Contributor Author

The Context object which contains the request log seems to be available at the Request level but I'm not sure if the IpfsNode has a direct access to it (for example to check it during the teardown procedure). I'll try to take a closer look at the ipfs diag cmds command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@schomatis schomatis

Labels
status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schomatis