Support WithIgnoreProviders() in provider query manager #10765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `Routing.IgnoreProviders`. This requires initializing a custom providerQueryManager and using it instead of the default created internally in Bitswap. Since the default is created with some internal default configuration options (MaxProviders), this hardcodes it.
hsanjuan
force-pushed
the
ignore-providers
branch
from
e955473 to
ecca2eb
Compare
gammazero
approved these changes
Apr 1, 2025
lidel
reviewed
Apr 2, 2025
| // internal setting in boxo. | ||
| pqm, err := rpqm.New(bitswapNetwork, | ||
| in.Rt, | ||
| rpqm.WithMaxProviders(10), |
There was a problem hiding this comment.
@hsanjuan why do we hardcode 10 here?
Wasn't previous default DefaultMaxProviders = 0 (unlimited) from boxo/routing/providerquerymanager/providerquerymanager.go?
limiting to 10 feels like DoS vector, no?
There was a problem hiding this comment.
Yes, this is the value we always used:
https://github.com/ipfs/boxo/blob/main/bitswap/client/client.go#L209
When passing in the pqm explicitally we need to set it...
No change on that front. As to why 10... 🤷 In rainbow we do unlimited, but in Kubo we never ventured to change the default of 10.
There was a problem hiding this comment.
Thanks! Feels we should avoid hardcoding magic numbers without docs, opened #10773 to sort this out + maybe align with rainbow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Routing.IgnoreProviders.This requires initializing a custom providerQueryManager and using it instead of the default created internally in Bitswap. Since the default is created with some internal default configuration options (MaxProviders), this hardcodes it.