Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicit bind_kernel in %qtconsole #1315

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Remove implicit bind_kernel in %qtconsole #1315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13ccad1
Remove implicit bind_kernel in `%qtconsole`
minrk Feb 4, 2025
aea457a
Sync with main
minrk Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions ipykernel/zmqshell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,14 +398,6 @@ def qtconsole(self, arg_s):
Useful for connecting a qtconsole to running notebooks, for better
debugging.
"""

# %qtconsole should imply bind_kernel for engines:
# FIXME: move to ipyparallel Kernel subclass
if "ipyparallel" in sys.modules:
from ipyparallel import bind_kernel

bind_kernel()

try:
connect_qtconsole(argv=arg_split(arg_s, os.name == "posix"))
except Exception as e:
Expand Down
Loading