Skip to content

[several] Refactor, stage 2, take 2#185

Open
SwooshyCueb wants to merge 60 commits into
irods:mainfrom
SwooshyCueb:refactor2.m
Open

[several] Refactor, stage 2, take 2#185
SwooshyCueb wants to merge 60 commits into
irods:mainfrom
SwooshyCueb:refactor2.m

Conversation

@SwooshyCueb

@SwooshyCueb SwooshyCueb commented Mar 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Supersedes #113
Addresses #106
Addresses #109
Addresses #163
Addresses #164
Addresses #183
Addresses #184
Addresses #186
Addresses #190 (maybe)
Addresses #191
Addresses #192

@SwooshyCueb

SwooshyCueb commented Mar 10, 2026

Copy link
Copy Markdown
Member Author

At present, this PR establishes an AMQP connection just fine, but doesn't actually send any messages. I think this is because the thread with the proton container gets left behind when the agent forks. Might have to use IPC.

@SwooshyCueb SwooshyCueb mentioned this pull request Mar 10, 2026
Closed
@SwooshyCueb SwooshyCueb force-pushed the refactor2.m branch 10 times, most recently from 3d761cc to 43b0f51 Compare March 12, 2026 07:42
korydraughn
korydraughn reviewed Mar 18, 2026
View reviewed changes

@korydraughn korydraughn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to address these review comments after you get things working.

Comment thread include/irods/private/amqp_sender.hpp Outdated
Comment thread include/irods/private/amqp_sender.hpp Outdated
Comment thread include/irods/private/amqp_sender.hpp Outdated
Comment thread include/irods/private/amqp_sender.hpp Outdated
@SwooshyCueb SwooshyCueb force-pushed the refactor2.m branch 3 times, most recently from 6d756aa to ace23d3 Compare March 19, 2026 00:37
@SwooshyCueb SwooshyCueb mentioned this pull request Mar 19, 2026
Open
@SwooshyCueb SwooshyCueb force-pushed the refactor2.m branch 9 times, most recently from 41038a1 to abbb5d9 Compare March 25, 2026 17:10
@korydraughn

korydraughn commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Will this work require the admin to change their plugin configuration? If so, in what way?

@SwooshyCueb

SwooshyCueb commented Mar 30, 2026

Copy link
Copy Markdown
Member Author

Will this work require the admin to change their plugin configuration? If so, in what way?

Some things have moved, and some things have been deprecated, but for now, if you had a working configuration before, it should still work fine. You'll just get warnings in the logs. I plan to add better documentation for the new configuration

SwooshyCueb added 28 commits June 11, 2026 23:02
@SwooshyCueb
[106,109,163,164,184] Avoid asterisk-dereferencing nlohmann primitives
75a0234
@SwooshyCueb
[106,109,163,164,184] Return better error codes from config load
0838d18
@SwooshyCueb
[28] return INVALID_REGEXP if pep regex fails to compile
a246ddb
@SwooshyCueb
[106,109,163,164,184] Add some additional type checks
4870fce
@SwooshyCueb
[28] look at nlohmann-json exception id
a82cac7
@SwooshyCueb
[109] add leading slash to path fallback value
8c8e3fb
@SwooshyCueb
[28] do not mark amqp_config as initialized if using fallback values
7db9378
@SwooshyCueb
[184] Fix empty sasl mechanisms array handling
5382e1c
@SwooshyCueb
[186] Return error if opening AMQP connection times out
685ed36
@SwooshyCueb
[186] Avoid referencing out-of-scope variables in the work queues
e5d2fcb
@SwooshyCueb
[28] Skip subclassed unixfilesystem tests
1f7977e
@SwooshyCueb
[106,109,163,164,184,186] add catch2 test for configuration loading
3179c94
@SwooshyCueb
[squash] DELIVERIES alias comment in test
f18a959
@SwooshyCueb
[192] add failsafe configuration option
a357cd3
@SwooshyCueb
[squash] tweak configuration warning in readme
24c1d31
@SwooshyCueb
[squash] error string tweaks
08f2868
@SwooshyCueb
[28] Tweak for compiler/libstdc++ compatibility
105c376
@SwooshyCueb
[28] add plugin name to unit test names
31bae16
@SwooshyCueb
[28] add unit tests to test hook (quick n dirty)
03170b5
@SwooshyCueb
[squash] fix test hook typo
3d2dd8c
@SwooshyCueb
[190] Set container ID
0e69492
@SwooshyCueb
[28] Add additional detail to log messages
da8d552
@SwooshyCueb
[squash] becasue -> because
f5ed970
@SwooshyCueb
[28] Check return values from config and sender class methods
0d7b2e2
@SwooshyCueb
[squash] error string tweaks (pt2)
96ff88e
@SwooshyCueb
[NEW COMMITS START HERE] [28] Use case-insensitive parsing for enums
919f7d4
@SwooshyCueb
[28] Bump plugin version number to 5.1.0
6fd5c20
@SwooshyCueb
[DROP] set log level in re cfg script
2afe889
@SwooshyCueb

SwooshyCueb commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

This userscript may be useful for those interested in this PR
https://github.com/ludios/expand-everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trel trel trel left review comments
@korydraughn korydraughn korydraughn left review comments
@alanking alanking alanking left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SwooshyCueb @korydraughn @trel @alanking