Changes allowing audit plugin to work under Ubuntu 18 (master)#47
Open
d-w-moore wants to merge 2 commits into
Open
Changes allowing audit plugin to work under Ubuntu 18 (master)#47d-w-moore wants to merge 2 commits into
d-w-moore wants to merge 2 commits into
Conversation
Contributor
Author
|
This will have to wait a little bit longer til the jansson is replaced by nlohmann::json |
Member
|
awaiting #48 |
Member
|
needs a rebase here too. |
Contributor
|
I think this is already in main at some level. I will pull it into my repo to see what happens |
Contributor
|
The CMakeLists changes have been superceded by recent overhauls to the CMake system in this and other repositories. The version bump in the build hook is actually older than the one currently in there. I think we can close this PR without merging as the changes herein are already in main at some capacity. |
Member
|
okie doke. power through. |
Contributor
|
We can leave this open until we confirm the plugin works for 4.3.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.