cherry pick for skipping BytesBuf serialization#89
Open
trel wants to merge 2 commits into
Open
Conversation
korydraughn
approved these changes
May 12, 2022
alanking
approved these changes
May 12, 2022
alanking
left a comment
alanking
left a comment
Contributor
There was a problem hiding this comment.
Has this been tested? @korydraughn?
Contributor
|
No. I have not tested this. |
Contributor
|
Okay, just checking. Let's leave it til we can make sure this is okay. I don't foresee any issues. I can have a look tomorrow. |
|
How is this coming on folks? Any ETA for a release? |
Member
Author
|
You're interested in an Ubuntu18 package? |
Contributor
|
Running these tests will be a little less trivial than I first imagined because of the test hook and the age of 2.7.x. Promise I'll get to this soon. "Tomorrow" was a bit ambitious last time. |
I'm afraid so! |
Member
Author
|
I've sent an engineering build for your testing/approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.