Add dVRK needle-pass environment to contrib#6570
Draft
chrisvoncsefalvay wants to merge 8 commits into
Draft
Conversation
Move runtime imports behind lazy configuration strings and preserve inherited IK behaviour without CUDA synchronisation. Validate physical inputs and make invalid pose and jaw commands fail safe. Cache phase constants and cover the new action semantics and pre-application configuration loading.
Make the pinned PR 769 integration job blocking and let the source-build helper select supported active Python environments safely. Accept the unreleased 1.4 wheel without allowing a future major version. Execute the public retargeting graph with controller samples and require a non-empty, decodable qualification video.
7 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This draft PR replaces #6527, which was closed rather than rewriting its
main-based history. It is opened againstdevelopin response to @kellyguo11's maintainer feedback, which asked that the contribution move todevelopand that the task use the newisaaclab_tasks/contribarea.Part of the dVRK Extended Cinematic Universe: best read alongside NVIDIA/IsaacTeleop#769.
This adds a contact-driven dVRK PSM needle-pass environment, its pinned PSM asset configuration, and paired-controller XR teleoperation. The needle is initialised once during reset; runtime transfer is qualified from measured contacts and load without attaching or directly repositioning the needle.
The task now lives under
isaaclab_tasks.contrib.needle_passand is registered asIsaacContrib-NeedlePass-dVRK-IK-Abs. Thedevelopport also adds lazy runtime configuration imports, finite-input and controller-contract validation, fail-safe jaw and pose hold behaviour, and public teleoperation-pipeline coverage.Main changes
IsaacContrib-NeedlePass-dVRK-IK-Abs, with differential IK, contact observations, load-backed hand-off phases, rewards, termination criteria, and CUDA physics validation.isaaclab_assetsandisaaclab_tasks.Dependency status
NVIDIA/IsaacTeleop#769 is still open, and its dVRK retargeter API is not yet part of a release. The normal package dependency accepts
isaacteleop>=1.3.0,<2.0.0. Until a release in that range contains the dVRK API, the focused CI job and documented local-validation helper build the exact PR revisionca175df7afc8198cbba0592cd1b447b11a4f3165. The source-build helper can be removed after that API is released.Validation
./isaaclab.sh -f: all 22 pre-commit hooks passed../isaaclab.sh -p tools/changelog/cli.py check develop: both modified packages have valid fragments.Type of change
Screenshots
Checklist
./isaaclab.sh -f.source/<pkg>/changelog.d/for every touched package.CONTRIBUTORS.md.Big thanks to @kellyguo11 for the encouragement and advice on repo structure!