Touptek filterwheel calibration fix#102
Open
ntrost57 wants to merge 3 commits intoisbeorn:developfrom
Open
Conversation
isbeorn
reviewed
Nov 6, 2025
| sdk = sdk.Open(this.internalId); | ||
|
|
||
| // Read number of positions | ||
| sdk.get_Option(ToupTekAlikeOption.OPTION_FILTERWHEEL_SLOT, out var slotNum); |
Owner
There was a problem hiding this comment.
we should still get the slot number, but only do the workaround for those that don't report the number.
What happens on the older wheels for this getter, does it return zero? if yes then just do the workaround when there are no slots reported.
Contributor
Author
There was a problem hiding this comment.
Apparently, the new ones have internal storage. Not sure if they are already shipped. I have the AFW-L for testing, it always reports 7 after turning on.
lee-b
pushed a commit
to lee-b/nina-pins
that referenced
this pull request
Apr 1, 2026
* switches * fixing wrong aux_interface enum * gauges and notify on (externally) changed values * update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Purpose
🧪 How Was It Tested?
Tested with AFW-L (2025 version).
✅ PR Checklist
Changelog.mdupdated (if applicable)🔗 Related Issues
📸 Screenshots
📝 Additional Notes