Fix handling of multiple packets in a single read #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If multiple packets are read in a single read operation the library can fail to process all but the first packet. This wont yet work on normal bind until [issue 4416](https://gitlab.isc.org/isc-projects/bind9/-/issues/4416) in upstream bind9 is fixed.
raybellis
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple packets are read in a single read operation the library can fail to process all but the first packet. This wont yet work on normal bind until issue 4416 in upstream bind9 is fixed.
Note that the nonce of a connection, once set, can never change, which is why having multiple commands inflight at the same time is fine from a protocol point of view.