fix: preserve dynamo cargo rustflags during source install - #213
fix: preserve dynamo cargo rustflags during source install#213weireweire wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the Python Dynamo bindings build process in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/srtctl/core/schema.py`:
- Line 730: The file fails CI formatting due to the string line containing
"maturin build --config 'build.rustflags=[\"-C\",\"target-cpu=native\"]' -o /tmp
&& "; fix by running the project formatter as suggested (run: `uv run ruff
format --write src/srtctl/`) or apply equivalent ruff/black formatting to
src/srtctl/core/schema.py so the offending string and surrounding lines are
reformatted to match the code style.
| "cd lib/bindings/python/ && " | ||
| 'export RUSTFLAGS="${RUSTFLAGS:-} -C target-cpu=native" && ' | ||
| "maturin build -o /tmp && " | ||
| "maturin build --config 'build.rustflags=[\"-C\",\"target-cpu=native\"]' -o /tmp && " |
There was a problem hiding this comment.
Fix formatting to pass CI pipeline.
The pipeline reports that this file needs reformatting: "1 file would be reformatted: src/srtctl/core/schema.py."
Run uv run ruff format --write src/srtctl/ to fix the formatting issue.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/srtctl/core/schema.py` at line 730, The file fails CI formatting due to
the string line containing "maturin build --config
'build.rustflags=[\"-C\",\"target-cpu=native\"]' -o /tmp && "; fix by running
the project formatter as suggested (run: `uv run ruff format --write
src/srtctl/`) or apply equivalent ruff/black formatting to
src/srtctl/core/schema.py so the offending string and surrounding lines are
reformatted to match the code style.
Summary
Verification
Summary by CodeRabbit