fix: use maturin build --release for dynamo source installs - #248
fix: use maturin build --release for dynamo source installs#248ishandhanani wants to merge 1 commit into
Conversation
Debug builds (`maturin build` without `--release`) produce binaries that are ~40% slower than release-optimized pip wheels, causing misleading benchmark comparisons. Also removes `-C target-cpu=native` which caused a separate release-mode bug with /v1/completions streaming. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughModified the Dynamo source-install command in Changes
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Debug builds (
maturin buildwithout--release) produce binaries that are ~40% slower than release-optimized pip wheels, causing misleading benchmark comparisons. Also removes-C target-cpu=nativewhich caused a separate release-mode bug with /v1/completions streaming.Summary by CodeRabbit