Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

fix: use maturin build --release for dynamo source installs - #248

Open
ishandhanani wants to merge 1 commit into
mainfrom
fix-maturin-release-build
Open

fix: use maturin build --release for dynamo source installs#248
ishandhanani wants to merge 1 commit into
mainfrom
fix-maturin-release-build

Conversation

@ishandhanani

@ishandhanani ishandhanani commented Apr 7, 2026

Copy link
Copy Markdown
Owner

Debug builds (maturin build without --release) produce binaries that are ~40% slower than release-optimized pip wheels, causing misleading benchmark comparisons. Also removes -C target-cpu=native which caused a separate release-mode bug with /v1/completions streaming.

Summary by CodeRabbit

  • Chores
    • Optimized the Dynamo build process for improved compatibility and performance, adjusting compilation flags and switching to explicit release builds.

Debug builds (`maturin build` without `--release`) produce binaries that
are ~40% slower than release-optimized pip wheels, causing misleading
benchmark comparisons. Also removes `-C target-cpu=native` which caused
a separate release-mode bug with /v1/completions streaming.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6155c023-3517-439c-ad10-973a8e23b42e

📥 Commits

Reviewing files that changed from the base of the PR and between 7df077b and 7535355.

📒 Files selected for processing (1)
  • src/srtctl/core/schema.py

📝 Walkthrough

Walkthrough

Modified the Dynamo source-install command in DynamoConfig.get_install_commands() by removing the -C target-cpu=native CPU-specific flag from RUSTFLAGS while retaining --cfg tokio_unstable, and changed the maturin invocation from a default build to an explicit release build.

Changes

Cohort / File(s) Summary
Dynamo Build Configuration
src/srtctl/core/schema.py
Removed -C target-cpu=native from RUSTFLAGS and added --release flag to maturin build invocation in DynamoConfig.get_install_commands()

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly Related PRs

  • fix dynamo source build #225: Modifies the same DynamoConfig.get_install_commands() method with adjustments to RUSTFLAGS and maturin build parameters in the Dynamo source-install command.
  • basic updates to qwen recipie #80: Directly related through prior modifications to the Dynamo source-install command in the same method, including the RUSTFLAGS CPU flag and maturin build settings.

Poem

🐰 A rabbit hops through build flags with care,
Removing native CPU, keeping configs fair,
Release builds faster, no more default way,
Tokio whispers remain to save the day! 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: switching from default debug builds to explicit release builds using maturin build --release for Dynamo source installations.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-maturin-release-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant