OD-17088_Groovy_4_upgrade_without_gradle_update #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlitvinko
force-pushed
the
OD-17088_Groovy_4_upgrade_without_gradle_update
branch
from
c5f356f to
0e2260e
Compare
dlitvinko
force-pushed
the
OD-17088_Groovy_4_upgrade_without_gradle_update
branch
2 times, most recently
from
64e4a51 to
7a4ea4e
Compare
… (generate Boolean getter like getAttribute() instead of isAttribute()), fixed generic issues, increased maximum heap size to build onCourse with Groovy 4.0.2 and to run tests
…groovy" in integration tests, fixed NullPointerException when use Mockito.when() in CourseClassUtilTest.testAddModuleToAllSessions():106 "when(courseClass.getSessions()).thenReturn(sessions)"
…ruction, fixed isPortrait() for ReportOverlay to use 'ReportOverlay.portrait' construction and fixed casting error for AbstractInvoice
dlitvinko
force-pushed
the
OD-17088_Groovy_4_upgrade_without_gradle_update
branch
from
7a4ea4e to
ad00b92
Compare
…voiceLine.setInvoice, groovy used setInvoice(AbstractInvoice ) from InvoiceLine when set Invoice class but groovy must use setInvoice(Invoice ) from _InvoiceLine. That is why before commit InvoiceLine can't getAbstractInvoice. This issue was only for groovy and when we use setter like invoiceLine.invoice = incoice (not invoiceLine.setInvoice(invoice)). But groove team fixed this bug in 3.0.8 version (https://issues.apache.org/jira/browse/GROOVY-9893)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.