Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset current directory after test completion #34

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

islas
Copy link
Owner

@islas islas commented Jan 7, 2025

When running multiple tests with mapped relative directories, the working directory will be changed to the mapped directory. However, if running in a process pool, the next test to pick up a worker that has already run with a different working directory will start in that wrong directory and thus the relative directory change will not be executed from the expected location.

To ensure processes in a pool always hand off at a known directory the current directory is stashed and subsequently popped after testing, regardless of test outcome.

@islas islas added the test Require testing label Jan 7, 2025
@github-actions github-actions bot removed the test Require testing label Jan 7, 2025
@islas islas merged commit 378728c into main Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant