refactor(tasks): drop legacy prepare() pattern

Author: alexblom

lib/commands/build.js

@@ -90,7 +90,7 @@ module.exports = Command.extend({
           return cordovaTarget.build();
         }
       })
-      .then(hook.prepare('afterBuild', options))
+      .then(() => hook.run('afterBuild', options))
       .then(() => lint.run())
       .then(function() {
         logger.success('ember-cordova project built');

lib/commands/prepare.js

@@ -25,8 +25,8 @@ module.exports = Command.extend({
     });
 
     return hook.run('beforePrepare', options)
-      .then(prepare.prepare())
-      .then(hook.prepare('afterPrepare', options))
+      .then(() => prepare.run())
+      .then(() => hook.run('afterPrepare', options))
       .catch(function(err) {
         logger.error(err);
       });

lib/commands/serve.js

@@ -78,14 +78,14 @@ module.exports = Command.extend({
     return editXml.addNavigation(project, reloadUrl)
       .then(() => cordovaTarget.validateServe())
       .then(() => framework.validateServe(opts))
-      .then(hook.prepare('beforeBuild', opts))
-      .then(setupLivereload.prepare(reloadUrl))
+      .then(() => hook.run('beforeBuild', opts))
+      .then(() => setupLivereload.run(reloadUrl))
       .then(function() {
         if (opts.skipCordovaBuild !== true) {
           return cordovaTarget.build();
         }
       })
-      .then(hook.prepare('afterBuild', opts))
+      .then(() => hook.run('afterBuild', opts))
       .then(function() {
         if (opts.skipFrameworkBuild !== true) {
           return framework.serve(opts, ui);

lib/frameworks/vue/tasks/build.js

@@ -19,7 +19,6 @@ module.exports = Task.extend({
       command: `cp -R ${this.buildPath}/* ${this.cordovaOutputPath}`
     });
 
-    return build.run()
-      .then(copy.prepare());
+    return build.run().then(() => copy.run());
   }
 });

lib/tasks/-task.js

@@ -1,12 +1,3 @@
 const Task             = require('ember-cli/lib/models/task');
 
-module.exports = Task.extend({
-  prepare() {
-    let task = this;
-    let args = Array.prototype.slice.call(arguments);
-
-    return function preparedTask() {
-      return task.run.apply(task, args);
-    };
-  }
-});
+module.exports = Task.extend();

node-tests/unit/frameworks/vue/tasks/build-test.js

@@ -16,11 +16,6 @@ describe('Vue Build Task', function() {
       return Promise.resolve();
     });
 
-    td.replace(Bash.prototype, 'prepare', function() {
-      tasks.push('bash-task-2');
-      return Promise.resolve();
-    });
-
     buildTask = new Build({
       buildCommand: 'fakeBuildCommand',
       buildPath: 'fakePath',
@@ -36,7 +31,7 @@ describe('Vue Build Task', function() {
     return buildTask.run({cordovaOutputPath: 'fakePath'}).then(function() {
       expect(tasks).to.deep.equal([
         'bash-task',
-        'bash-task-2'
+        'bash-task'
       ]);
     });
   });