Merged
Conversation
Contributor
Qodana Community for JVM5 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
Contributor
Qodana Community for JVM4 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
Use StringJoiner for LPQ building within FeatureModelPsiImplUtil
HerrKermet
approved these changes
Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make using LPQ instead of just featurename voluntary even if featurename is unique.
Description
LPQ are used to make sure we can correctly identify features with the same name by using the parent feature as well. However sometimes when annotating additional clarity is required. Therefore this PR suggest adding changes such that you can voluntarily add an LPQ instead of just the feature name such that the annotation is clearer. If there are duplicated featurenames LPQs are still required.
How Has This Been Tested?
I tested by using the Snake repository and using the two snake features which are duplicates to ensure the previous functionality still works while using the ... feature and defining it with an lpq instead of just the feature name.
Screenshots (if appropriate):
feature metrics are still using only required LPQs:
Types of changes
Checklist: