spire: update injection template to customize native sidecars #16843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/XS
istio-testing
added
size/S
dhawton
reviewed
Sep 3, 2025
| fi | ||
| export KIND_IP_FAMILY | ||
| export NODE_IMAGE="gcr.io/istio-testing/kind-node:v1.31.0" | ||
| export NODE_IMAGE="" |
There was a problem hiding this comment.
Native sidecars are not enabled on KIND 1.31, so the integration tests for spire worked fine and didn't capture the issue with patching containers, instead of initContainers, so I upgraded the node image, but now other tests fail.
Signed-off-by: Jacek Ewertowski <[email protected]>
Signed-off-by: Jacek Ewertowski <[email protected]>
Signed-off-by: Jacek Ewertowski <[email protected]>
jewertow
force-pushed
the
spire-injection-template-init-containers
branch
from
9e0b007 to
4a3d257
Compare
Signed-off-by: Jacek Ewertowski <[email protected]>
|
/retest |
|
@jewertow: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closed in favor of #16866 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The injection template for SPIRE does not work with Istio 1.27 that enables native sidecars by default.
Reviewers