Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release-1.5] update download url to the latest link #6703

Merged
merged 3 commits into from
Mar 5, 2020
Merged

[Release-1.5] update download url to the latest link #6703

merged 3 commits into from
Mar 5, 2020

Conversation

FeynmanZhou
Copy link
Contributor

@FeynmanZhou FeynmanZhou commented Mar 3, 2020 •
edited by istio-policy-bot
Loading

[ ] Configuration Infrastructure
[X ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@FeynmanZhou FeynmanZhou requested a review from a team as a code owner March 3, 2020 16:56
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 3, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2020
@istio-testing
Copy link
Contributor

Hi @FeynmanZhou. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FeynmanZhou
Copy link
Contributor Author

FeynmanZhou commented Mar 3, 2020 •
edited
Loading

@ericvn Update the download link to sync with KubeSphere. Please help to review the updates.
BTW, we are looking forward to the Istio 1.5 to be release!

ericvn
ericvn reviewed Mar 3, 2020
View reviewed changes
content/en/docs/setup/platform-setup/kubesphere/index.md

{{< text bash >}}
$ curl -L https://kubesphere.io/download/stable/v2.1.0 > installer.tar.gz
$ curl -L https://kubesphere.io/download/stable/latest > installer.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the best way to handle latest and then specifying a particular version on the cd and then there k8s versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericvn
I think it could be better that do not specify a particular version, which means I can change cd kubesphere-all-v2.1.1 to cd kubesphere-all-${version} instead. For k8s version, it should be manually updated when version changes. How do you think of this way?

Copy link
Contributor

@ericvn ericvn Mar 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I look at https://preliminary.istio.io/docs/setup/getting-started/#download (although I know that page is being reworked so it might change soon), but I could see saying something like:

Change to the Kubesphere directory. For example, if the created directory is kubesphere-all-v2.2.0, `cd kubesphere-all-v2.2.0`

Or maybe you keep the text bash with the cd so they can cut/paste (although if they have completion turned on, it's just type cd<tab> to get it filled out).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then maybe remove the Kubernetes versions since they will change over time and not require updates to this doc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, I have modified it accordingly. Please help to review the updates.

@ericvn
Copy link
Contributor

ericvn commented Mar 4, 2020

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Mar 4, 2020
@ericvn
Copy link
Contributor

ericvn commented Mar 4, 2020

As a side note, I see #6704 was opened for issues with Kubesphere.

@FeynmanZhou
Copy link
Contributor Author

As a side note, I see #6704 was opened for issues with Kubesphere.

Yes, already replied in #6704 .

@FeynmanZhou FeynmanZhou requested a review from ericvn March 5, 2020 15:07
@adammil2000 adammil2000 changed the title update download url to the latest link [Release-1.5] update download url to the latest link Mar 5, 2020
@istio-testing istio-testing merged commit 65e1b16 into istio:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvn ericvn ericvn approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FeynmanZhou @istio-testing @ericvn @googlebot @istio-policy-bot