consistent redis configs except event api #85

README.md

@@ -52,14 +52,13 @@ As of initial version, Redis will act as the database for engine operations cons
 
 ## Running Modes
 
-### Engine as a service
+**Note**: The important thing about Redis.
 
-This is a full deployment with all the components as shown in [Architecture](#architecture-of-oasis).
-This provides out-of-the-box components which can be used by your applications.
-
-For testing purpose, a docker compose setup has been provided to up and running locally.
-
-Kubernetes and AWS solution are still pending.
+> Redis must be configured in [Replication mode](https://redis.io/topics/replication) 
+to not losing data. Because all earned game rewards and current processing states are being stored in the Redis.
+That means primary database for the engine is the Redis. If you want to store those rewards 
+in a more durable database like SQL, MongoDB or any NoSQL solution, you can explicitly
+intercept through engine by providing a custom signal subscription instance.
 
 ### Embedding Engine
 
@@ -122,6 +121,16 @@ public static void main(String[] args) throws Exception {
 
 Check the methods of `OasisEngine` class how you can submit your events/rules/game commands.
 
+### Engine as a service
+
+This is a full deployment with all the components as shown in [Architecture](#architecture-of-oasis).
+This provides out-of-the-box components which can be used by your applications.
+
+For testing purpose, a docker compose setup has been provided to up and running locally.
+
+Kubernetes and AWS solution are still pending.
+
+
 ## Concepts
 
 This section will introduce you to the concepts around the Oasis framework.

engine/src/main/resources/reference.conf

@@ -40,4 +40,15 @@ oasis {
             }
         }
     }
+
+    redis = {
+        host: "localhost"
+        port: 6379
+
+        pool {
+            max: 16
+            maxIdle: 8
+            minIdle: 4
+        }
+    }
 }

externals/redis/src/main/java/io/github/oasis/db/redis/RedisDb.java

@@ -45,6 +45,12 @@ public class RedisDb implements Db {
 
     private static final Logger LOG = LoggerFactory.getLogger(RedisDb.class);
 
+    private static final String LOCALHOST = "localhost";
+    private static final int DEFAULT_PORT = 6379;
+    private static final int POOL_MAX = 8;
+    private static final int POOL_MAX_IDLE = 2;
+    private static final int POOL_MIN_IDLE = 2;
+
     private final JedisPool pool;
     private final Map<String, RedisScript> scriptReferenceMap = new ConcurrentHashMap<>();
 
@@ -53,12 +59,14 @@ private RedisDb(JedisPool pool) {
     }
 
     public static RedisDb create(OasisConfigs configs) {
-        String host = configs.get("oasis.db.host", "localhost");
-        int port = configs.getInt("oasis.db.port", 6379);
-        int poolSize = configs.getInt("oasis.db.pool.max", 5);
-        int maxIdle = configs.getInt("oasis.db.pool.maxIdle", -1);
-        int minIdle = configs.getInt("oasis.db.pool.minIdle", -1);
-
+        String host = configs.get("oasis.redis.host", LOCALHOST);
+        int port = configs.getInt("oasis.redis.port", DEFAULT_PORT);
+        int poolSize = configs.getInt("oasis.redis.pool.max", POOL_MAX);
+        int maxIdle = configs.getInt("oasis.redis.pool.maxIdle", POOL_MAX_IDLE);
+        int minIdle = configs.getInt("oasis.redis.pool.minIdle", POOL_MIN_IDLE);
+
+        LOG.debug("Connecting to redis in {}:{}...", host, port);
+        LOG.debug("  - With pool configs max: {}, maxIdle: {}, minIdle: {}", poolSize, maxIdle, minIdle);
         JedisPoolConfig poolConfig = new JedisPoolConfig();
         if (maxIdle > 0) poolConfig.setMaxIdle(maxIdle);
         if (minIdle > 0) poolConfig.setMinIdle(minIdle);

services/stats-api/src/main/resources/application.conf

@@ -18,13 +18,18 @@ oasis = {
 
   defaultApiKey = "root:root"
 
-  redis = {
-    connectionString: "redis://localhost:6379"
-    maxPoolSize: 4
-    maxWaitingHandlers: 16
+  redis {
+    host: "localhost"
+    port: 6379
 
     connectionRetries: 5
     connectionRetryDelay: 5000
+
+    pool = {
+      max: 16
+      maxIdle: 16
+      minIdle: 4
+    }
   }
 
   dispatcher = {

simulations/src/main/resources/application.conf

@@ -14,6 +14,16 @@ oasis {
     rule = 5
     signal = 10
   }
+  redis = {
+    host: "localhostxxx"
+    port: 6379
+
+    pool {
+      max: 16
+      maxIdle: 8
+      minIdle: 4
+    }
+  }
   dispatcher = {
     configs = {
       host: "localhost"