module definition spec made serializable #123

isuru89 · Jul 31, 2022 · e86f4bd · e86f4bd
1 parent 5789bf3
commit e86f4bd
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/core/src/main/java/io/github/oasis/core/elements/ModuleDefinition.java b/core/src/main/java/io/github/oasis/core/elements/ModuleDefinition.java
@@ -38,7 +38,7 @@ public class ModuleDefinition implements Serializable {
     private Specs specs;
 
     @Data
-    public static class Specs {
+    public static class Specs implements Serializable {
         private Map<String, Object> feeds;
         private Map<String, Object> rules;
 

diff --git a/docs/life-cycle-of-game.md b/docs/life-cycle-of-game.md
@@ -1,5 +1,15 @@
 # Life Cycle of a Game
 
+```mermaid
+graph TD
+    A[CREATED] -->|start| B(STARTED)
+    B --> |pause| D[PAUSED]
+    B --> |stop| E[REMOVED]
+    D --> |stop| E
+    D --> |resume| B
+```
+
+
 ### Starting a Game
  1. Admin defines a new game in the admin API
     1. This will cause to create a game record in admin db

diff --git a/...tats-api/src/main/java/io/github/oasis/core/services/api/services/impl/ModuleService.java b/...tats-api/src/main/java/io/github/oasis/core/services/api/services/impl/ModuleService.java
@@ -56,7 +56,7 @@ public List<ModuleDefinition> listAllModuleDefinitions() {
                 .collect(Collectors.toList());
     }
 
-    @Cacheable(value = ID.CACHE_MODULES, key = "moduleId")
+    @Cacheable(value = ID.CACHE_MODULES, key = "#p0")
     @Override
     public ModuleDefinition getModuleDefinition(String moduleId) {
         return statsApiContext.getElementModules().stream()