ci(security): consolidate SBOM schedule - #1785
Merged
Merged
Conversation
Contributor
❓ Code Generation Drift DetectionStatus: Automated by AE-Framework Codegen |
Collaborator
Author
Auto Update BranchPR #1785 was behind base; triggered branch update. |
Contributor
❓ Code Generation Drift DetectionStatus: Automated by AE-Framework Codegen |
27 tasks
Contributor
Quality Summary
|
Contributor
🔍 Verification Summary
Unlinked (top 5)- Device registration publishes enough pre-keys and emits audit log (id: device-registration-publishes-enough-pre-keys-and-emits-audit-log) test:N/A impl:N/A formal:N/A - Invalid auth tag triggers audit violation for AES-GCM envelopes (id: invalid-auth-tag-triggers-audit-violation-for-aes-gcm-envelopes) test:N/A impl:N/A formal:N/A - Session rotation stays within forward secrecy thresholds (id: session-rotation-stays-within-forward-secrecy-thresholds) test:N/A impl:N/A formal:N/ALinked examples (up to 3)- Successful reservation (id: successful-reservation) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/b2f8cd92649151e438b5a5d24cf2c4d8058a3796/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/b2f8cd92649151e438b5a5d24cf2c4d8058a3796/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/b2f8cd92649151e438b5a5d24cf2c4d8058a3796/specs/formal/tla+/Inventory.tla) - Prevent negative stock (id: prevent-negative-stock) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/b2f8cd92649151e438b5a5d24cf2c4d8058a3796/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/b2f8cd92649151e438b5a5d24cf2c4d8058a3796/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/b2f8cd92649151e438b5a5d24cf2c4d8058a3796/specs/formal/tla+/Inventory.tla) - Idempotent by order id (id: idempotent-by-order-id) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/b2f8cd92649151e438b5a5d24cf2c4d8058a3796/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/b2f8cd92649151e438b5a5d24cf2c4d8058a3796/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/b2f8cd92649151e438b5a5d24cf2c4d8058a3796/specs/formal/tla+/Inventory.tla)Hit basis (tests/formal)- Test hits: title=3 id=0 tag=0 - Formal hits: title=0 id=3 tag=0Non-OK modules (top 5)- KvOnce (log: artifacts/codex/KvOnce.tlc.log.txt) - KvOnceRefinement (log: artifacts/codex/KvOnceRefinement.tlc.log.txt) - KvOnceImpl (log: artifacts/codex/KvOnceImpl.tlc.log.txt) - KvOnce (log: artifacts/codex/KvOnce.tlc.log.txt) - KvOnceRefinement (log: artifacts/codex/KvOnceRefinement.tlc.log.txt) |
Contributor
CodeX Artifacts Summary
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the SBOM generation schedule into the security workflow to reduce redundancy and improve workflow organization. The SBOM generation previously ran on its own weekly schedule but is now invoked by the security workflow via workflow_call when triggered by schedule or manual dispatch events.
Changes:
- Removed the standalone weekly schedule (Mon 05:40 UTC) from sbom-generation.yml and added workflow_call trigger
- Added sbom-generation job to security.yml that invokes sbom-generation.yml on schedule/dispatch events
- Updated input handling in sbom-generation.yml to support both workflow_call and workflow_dispatch triggers
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/security.yml |
Adds new sbom-generation job that invokes the SBOM workflow via workflow_call on schedule/dispatch events with required permissions |
.github/workflows/sbom-generation.yml |
Removes standalone schedule trigger, adds workflow_call event support, and updates input handling to work with both workflow_call and workflow_dispatch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2f8cd9264
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
CI Status Snapshot (2026-01-27T03:31:45.292Z)
|
Contributor
❓ Code Generation Drift DetectionStatus: Automated by AE-Framework Codegen |
Collaborator
Author
|
レビューコメント対応しました。
コンフリクトはありません（rebase 済み、mergeable 状態）。 |
Contributor
🔍 Verification Summary
Unlinked (top 5)- Device registration publishes enough pre-keys and emits audit log (id: device-registration-publishes-enough-pre-keys-and-emits-audit-log) test:N/A impl:N/A formal:N/A - Invalid auth tag triggers audit violation for AES-GCM envelopes (id: invalid-auth-tag-triggers-audit-violation-for-aes-gcm-envelopes) test:N/A impl:N/A formal:N/A - Session rotation stays within forward secrecy thresholds (id: session-rotation-stays-within-forward-secrecy-thresholds) test:N/A impl:N/A formal:N/ALinked examples (up to 3)- Successful reservation (id: successful-reservation) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/0706b1b2b8a85c531ec4e9b80cbcb484f61ce10a/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/0706b1b2b8a85c531ec4e9b80cbcb484f61ce10a/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/0706b1b2b8a85c531ec4e9b80cbcb484f61ce10a/specs/formal/tla+/Inventory.tla) - Prevent negative stock (id: prevent-negative-stock) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/0706b1b2b8a85c531ec4e9b80cbcb484f61ce10a/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/0706b1b2b8a85c531ec4e9b80cbcb484f61ce10a/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/0706b1b2b8a85c531ec4e9b80cbcb484f61ce10a/specs/formal/tla+/Inventory.tla) - Idempotent by order id (id: idempotent-by-order-id) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/0706b1b2b8a85c531ec4e9b80cbcb484f61ce10a/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/0706b1b2b8a85c531ec4e9b80cbcb484f61ce10a/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/0706b1b2b8a85c531ec4e9b80cbcb484f61ce10a/specs/formal/tla+/Inventory.tla)Hit basis (tests/formal)- Test hits: title=3 id=0 tag=0 - Formal hits: title=0 id=3 tag=0Non-OK modules (top 5)- KvOnce (log: artifacts/codex/KvOnce.tlc.log.txt) - KvOnceRefinement (log: artifacts/codex/KvOnceRefinement.tlc.log.txt) - KvOnceImpl (log: artifacts/codex/KvOnceImpl.tlc.log.txt) - KvOnce (log: artifacts/codex/KvOnce.tlc.log.txt) - KvOnceRefinement (log: artifacts/codex/KvOnceRefinement.tlc.log.txt) |
Contributor
CodeX Artifacts Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- move SBOM weekly schedule into security workflow and invoke via workflow_call\n- keep PR/push SBOM behavior intact while consolidating schedule\n- ensure reusable workflow has required permissions for attestations\n\n## Testing\n- not run (workflow change)