ci(release): consolidate quality artifacts - #1787
Merged
Merged
Conversation
Contributor
❓ Code Generation Drift DetectionStatus: Automated by AE-Framework Codegen |
27 tasks
Contributor
Quality Summary
|
Contributor
🔍 Verification Summary
Unlinked (top 5)- Device registration publishes enough pre-keys and emits audit log (id: device-registration-publishes-enough-pre-keys-and-emits-audit-log) test:N/A impl:N/A formal:N/A - Invalid auth tag triggers audit violation for AES-GCM envelopes (id: invalid-auth-tag-triggers-audit-violation-for-aes-gcm-envelopes) test:N/A impl:N/A formal:N/A - Session rotation stays within forward secrecy thresholds (id: session-rotation-stays-within-forward-secrecy-thresholds) test:N/A impl:N/A formal:N/ALinked examples (up to 3)- Successful reservation (id: successful-reservation) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/0b88b0f3b78fcebb219705be282ac37d907e21fd/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/0b88b0f3b78fcebb219705be282ac37d907e21fd/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/0b88b0f3b78fcebb219705be282ac37d907e21fd/specs/formal/tla+/Inventory.tla) - Prevent negative stock (id: prevent-negative-stock) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/0b88b0f3b78fcebb219705be282ac37d907e21fd/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/0b88b0f3b78fcebb219705be282ac37d907e21fd/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/0b88b0f3b78fcebb219705be282ac37d907e21fd/specs/formal/tla+/Inventory.tla) - Idempotent by order id (id: idempotent-by-order-id) test: [traceability/inventory.trace.test.ts](https://github.com/itdojp/ae-framework/blob/0b88b0f3b78fcebb219705be282ac37d907e21fd/tests/traceability/inventory.trace.test.ts) impl: [domain/inventory.ts](https://github.com/itdojp/ae-framework/blob/0b88b0f3b78fcebb219705be282ac37d907e21fd/src/domain/inventory.ts) formal: [tla+/Inventory.tla](https://github.com/itdojp/ae-framework/blob/0b88b0f3b78fcebb219705be282ac37d907e21fd/specs/formal/tla+/Inventory.tla)Hit basis (tests/formal)- Test hits: title=3 id=0 tag=0 - Formal hits: title=0 id=3 tag=0Non-OK modules (top 5)- KvOnce (log: artifacts/codex/KvOnce.tlc.log.txt) - KvOnceRefinement (log: artifacts/codex/KvOnceRefinement.tlc.log.txt) - KvOnceImpl (log: artifacts/codex/KvOnceImpl.tlc.log.txt) - KvOnce (log: artifacts/codex/KvOnce.tlc.log.txt) - KvOnceRefinement (log: artifacts/codex/KvOnceRefinement.tlc.log.txt) |
Contributor
CodeX Artifacts Summary
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the release quality artifacts workflow by invoking it from the main release workflow via workflow_call, rather than having it triggered independently by release events.
Changes:
- Modified
release-quality-artifacts.ymlto useworkflow_callinstead of thereleaseevent trigger - Added a new job in
release.ymlto invoke the quality artifacts workflow after the main release job completes - Updated conditional logic to distinguish between workflow_call invocations and manual dispatches for proper artifact upload handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
Adds release-quality-artifacts job that calls the quality artifacts workflow after release completion with appropriate permissions |
.github/workflows/release-quality-artifacts.yml |
Replaces release event trigger with workflow_call and updates upload conditionals to handle both workflow_call and manual dispatch scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
CI Status Snapshot (2026-01-27T11:36:43.681Z)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- invoke release-quality-artifacts from release.yml via workflow_call\n- remove release trigger from release-quality-artifacts and keep manual dispatch\n- keep release asset upload behavior for tag releases\n\n## Testing\n- not run (workflow change)