Skip to content

Replace deprecated datetime.utcnow() with timezone-aware datetime #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace deprecated datetime.utcnow() with timezone-aware datetime #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71ba19d
Replace deprecated datetime.utcnow() with timezone-aware datetime
sklart Nov 5, 2025
4099f89
Replace deprecated datetime.utcnow() with timezone-aware datetime
sklart Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions mwscrape/scrape.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from urllib.parse import urlparse
from urllib.parse import urlunparse
from collections import namedtuple
from datetime import datetime, timedelta
from datetime import datetime, timedelta, timezone
from multiprocessing import RLock
from multiprocessing.pool import ThreadPool
from contextlib import contextmanager
Expand Down Expand Up @@ -336,7 +336,7 @@ def main():
site_host = session_doc["site"]
scheme, host = scheme_and_host(site_host)
db_name = session_doc["db_name"]
session_doc["resumed_at"] = datetime.utcnow().isoformat()
session_doc["resumed_at"] = datetime.now(timezone.utc).replace(tzinfo=None).isoformat()
if args.start:
start_page_name = args.start
else:
Expand All @@ -362,7 +362,7 @@ def main():
)
print("Starting session %s" % session_id)
sessions_db[session_id] = {
"created_at": datetime.utcnow().isoformat(),
"created_at": datetime.now(timezone.utc).isoformat(),
"site": site_host,
"db_name": db_name,
"descending": descending,
Expand Down Expand Up @@ -429,7 +429,7 @@ def recently_changed_pages(timestamp):
elif args.changes_since or args.recent:
if args.recent:
recent_days = args.recent_days
changes_since = fmt_mw_tms(datetime.utcnow() + timedelta(days=-recent_days))
changes_since = fmt_mw_tms(datetime.now(timezone.utc).replace(tzinfo=None) + timedelta(days=-recent_days))
else:
changes_since = args.changes_since.ljust(14, "0")
print("Getting recent changes (since %s)" % changes_since)
Expand Down Expand Up @@ -458,7 +458,7 @@ def update_session(title):
with lock:
session_doc = sessions_db[session_id]
session_doc["last_page_name"] = title
session_doc["updated_at"] = datetime.utcnow().isoformat()
session_doc["updated_at"] = datetime.now(timezone.utc).isoformat()
sessions_db[session_id] = session_doc

def process(page):
Expand Down