fix: DS3231 probe fix and constants cleanup#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes DS3231 probe
While checking if the hex value is
<= 0x59correctly filters out values where the tens digit is 6 or higher, it fails to catch invalid lower nibbles. For example, if a faulty read returns0x0A,0x1C, or0x4F, the function will evaluate them as <0x59and returntrue, even though A, C, and F are invalid in BCD.The updated function validates that both the tens digit and the ones digit fall within their valid decimal bounds:
tensDigit <= 5 && onesDigit <= 9.I2C Constants Refactor
I have removed various hard-coded constants and moved them into defines in
HalGPIO.h. For consistency and to provide a single location for relevant constants, I moved existingconstexprinto these defines as well.AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO