Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modrinth: more info in error when dependency has no applicable files #3142

Merged
merged 3 commits into from
Nov 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ RUN easy-add --var os=${TARGETOS} --var arch=${TARGETARCH}${TARGETVARIANT} \
--var version=${MC_SERVER_RUNNER_VERSION} --var app=mc-server-runner --file {{.app}} \
--from ${GITHUB_BASEURL}/itzg/{{.app}}/releases/download/{{.version}}/{{.app}}_{{.version}}_{{.os}}_{{.arch}}.tar.gz

ARG MC_HELPER_VERSION=1.40.2
ARG MC_HELPER_VERSION=1.40.4
ARG MC_HELPER_BASE_URL=${GITHUB_BASEURL}/itzg/mc-image-helper/releases/download/${MC_HELPER_VERSION}
# used for cache busting local copy of mc-image-helper
ARG MC_HELPER_REV=1
Expand Down
3 changes: 1 addition & 2 deletions tests/setuponlytests/vanillatweaks_file/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ services:
restart: "no"
image: ${IMAGE_TO_TEST:-itzg/minecraft-server}
environment:
VANILLATWEAKS_FILE: /config/vt-datapacks.json,/config/vt-craftingtweaks.json,/config/vt-resourcepacks.json
VANILLATWEAKS_FILE: /config/vt-datapacks.json,/config/vt-craftingtweaks.json
EULA: "TRUE"
SETUP_ONLY: "TRUE"
# the following are only used to speed up test execution
Expand All @@ -14,6 +14,5 @@ services:
- ./data:/data
- ./vt-datapacks.json:/config/vt-datapacks.json:ro
- ./vt-craftingtweaks.json:/config/vt-craftingtweaks.json:ro
- ./vt-resourcepacks.json:/config/vt-resourcepacks.json:ro
# the following are only used to speed up test execution
- ./verify.sh:/servers/fake.jar
1 change: 1 addition & 0 deletions tests/setuponlytests/vanillatweaks_file/require.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[[ $EXTENDED_TESTS ]] || exit 1