Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Disabling Mods in Generic Packs #3281

Merged
merged 7 commits into from
Jan 27, 2025
Merged

Conversation

azunaVT
Copy link
Contributor

@azunaVT azunaVT commented Jan 26, 2025

Adding the ability to disable mods for generic packs in start-setupModpack through a DISABLE_MODS environment variable.

Example of usage for something like running GTNH 2.7.2 with CrucibleMC, where lwjgl3ify and archaicfix need to be disabled for the pack to work:

  gtnh:
    image: itzg/minecraft-server
    container_name: gtnh
    tty: true
    stdin_open: true
    restart: unless-stopped
    environment:
      TYPE: CRUCIBLE
      VERSION: 1.7.10
      CRUCIBLE_RELEASE: staging-8ae5051
      GENERIC_PACKS: GT_New_Horizons_2.7.2_Server_Java_17-21
      GENERIC_PACKS_SUFFIX: .zip
      GENERIC_PACKS_PREFIX: https://downloads.gtnewhorizons.com/ServerPacks/
      DISABLE_MODS: |
        lwjgl3ify-2.1.5.jar
        archaicfix-0.7.4.jar
      ENABLE_QUERY: true
      EULA: TRUE
      MEMORY: 8G
      JVM_OPTS: -Dfml.readTimeout=180 @crucible-gtnh-java9args.txt
    ports:
      - '25565:25565'
    volumes:
      - ./gtnh/server:/data
      - ./gtnh/crucible-gtnh-java9args.txt:/data/crucible-gtnh-java9args.txt
      - ./gtnh/mods.txt:/data/mods.txt

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Now I see what you meant with the comment #3144 (comment)

Please also add a brief description of the variable to the docs at https://github.com/itzg/docker-minecraft-server/blob/master/docs/mods-and-plugins/index.md?plain=1#L61

…; Changed suffix from .DISABLED to .disabled
@azunaVT azunaVT requested a review from itzg January 26, 2025 23:16
@azunaVT azunaVT requested a review from itzg January 27, 2025 01:46
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super close 😀

@azunaVT azunaVT requested a review from itzg January 27, 2025 02:06
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@itzg itzg merged commit 6bb2c3a into itzg:master Jan 27, 2025
5 checks passed
@azunaVT azunaVT deleted the feat/Disabling_Mods branch January 27, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants