Fix Stop command quotes

[GrayR0ot]

Hello,

After the recent change which was the removal of the args.StopCommand replace it seems the command is now sent between quotes.

Here is the bug it produces:

The command that the server handle is not correctly parsed.

[itzg]

I'm wondering though how does it end up with quotes around it?

[itzg]

I just now tested with

--stop-command "stop 120"

and

--stop-command="stop 120"

and in both cases the args.StopCommand didn't have extra quotes.

[GrayR0ot]

On my side I'm using it that way in Dockerfile:

CMD ["mc-server-runner", "--stop-command", "\"stop 180\"", \
    "java", \
    "-Xms2G", \
    "-Xmx2G", \
    "-XX:+UseG1GC", \
    "-XX:+ParallelRefProcEnabled", \
    "-XX:MaxGCPauseMillis=200", \
    "-XX:+UnlockExperimentalVMOptions", \
    "-XX:+DisableExplicitGC", \
    "-XX:+AlwaysPreTouch", \
    "-XX:G1NewSizePercent=30", \
    "-XX:G1MaxNewSizePercent=40", \
    "-XX:G1HeapRegionSize=8M", \
    "-XX:G1ReservePercent=20", \
    "-XX:G1HeapWastePercent=5", \
    "-XX:G1MixedGCCountTarget=4", \
    "-XX:InitiatingHeapOccupancyPercent=15", \
    "-XX:G1MixedGCLiveThresholdPercent=90", \
    "-XX:G1RSetUpdatingPauseTimePercent=5", \
    "-XX:SurvivorRatio=32", \
    "-XX:+PerfDisableSharedMem", \
    "-XX:MaxTenuringThreshold=1", \
    "-Dusing.aikars.flags=https://mcflags.emc.gs", \
    "-Daikars.new.flags=true", \
    "-jar", "paper.jar"]

Or do you pass the stop command as the latest arg?

[itzg]

There's your extra quotes

"\"stop 180\""

Just use

"stop 180"

Since CMD will pass each element as a distinct argument to the Linux process call.

You might be getting confused about shell and exec forms. You're using exec form of CMD where the quoting you normally need from a shell is not needed

https://docs.docker.com/reference/dockerfile/#shell-and-exec-form

[GrayR0ot]

Oh damn, I didn't knew that ty