Skip to content

Minor improvements to README.md; Bug fix in go.mod #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,19 @@ docker run -it --rm \
-v ${PWD}:/build \
-w /build \
-p 2222:2222 \
golang:1.19
golang:1.23
```

Within that container, build/test by running:

```bash
go mod tidy
go run . test/dump.sh
go run . test/bash-only.sh

# Used to test remote console functionality
# Connect to this using an ssh client from outside the container to ensure two-way communication works
# Connect to this using an ssh client from outside the container to
# ensure two-way communication works (Default password: "minecraft")
go run . -remote-console /usr/bin/sh
# The following should fail
go run . --shell sh test/bash-only.sh
Expand Down
2 changes: 2 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ module github.com/itzg/mc-server-runner

go 1.23.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the second commit reverted this


toolchain go1.23.10

require (
github.com/google/uuid v1.6.0
github.com/itzg/go-flagsfiller v1.15.0
Expand Down