Feat/gradio types - #1145
Conversation
|
Someone is attempting to deploy a commit to the itzzavdhesh's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Review limit reached
Next review available in: 14 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (85)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
dco-missing
ci
client
documentation
✍️ DCO Sign-off NeededHey @desireddymohithreddy0925! 👋 One or more commits in this PR are missing a Warning
How to fix: For the latest commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits, replace git rebase --signoff HEAD~N
git push --force-with-leaseThis comment will update automatically after you push. 🤖 VoiceForge Automation · Updates automatically on edits |
🛠️ PR Needs UpdatesHey @desireddymohithreddy0925! 👋 A few things need fixing before a mentor can review this PR. Warning
How to fix:
Once fixed, the workflow re-runs automatically and pings the right mentor. 🤖 VoiceForge Automation · Updates automatically on edits |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
Hi @desireddymohithreddy0925 Your PR has Branch Conflict please resolve them and ping me after! Thanks |
2 participants
✨ Feature Description
This PR adds a
.d.tsdeclaration file to strictly type the inputs and outputs of the custom@gradio/clientwrapper used within the backend voice generation logic.Fixes #757
🤔 Problem It Solves
Previously, developers modifying the voice engine integration had zero IDE auto-complete for the payloads expected by the Hugging Face space. This lack of type safety frequently led to typos and server crashes during development.
💡 Proposed Solution
server/types/gradio.d.tsto strictly define the shapes of thePredictPayloadandPredictResponseinterfaces based on the Chatterbox model's API documentation.voiceController.jsand added ajsconfig.jsonso VSCode instantly provides rich IntelliSense without requiring a massive refactor of the backend to TypeScript.✅ Acceptance Criteria
🌱 Contributor Checklist
Summary by cubic
Add strict TypeScript types and JSDoc for the backend
@gradio/clientwrapper to make TTS requests type-safe and IDE-friendly. Also enforces lint/format in CI and includes small UI/accessibility polish, with a repo-wide Prettier formatting pass.New Features
server/types/gradio.d.tswith strict payload/response types; enabled IntelliSense via JSDoc andserver/jsconfig.json.voice_idfor re-clone and clear 404 when a voice isn’t cached (non-mock).requestVideoFrameCallback.Dependencies
.github/workflows/lint.yml),eslint.config.js,.lintstagedrc, and npm scriptslintandformat:check.Written for commit 4fb5f74. Summary will update on new commits.